LGTM.
http://codereview.chromium.org/7824038/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/7824038/diff/1/src/arm/full-codegen-arm.cc#newcode1816 src/arm/full-codegen-arm.cc:1816: // Global var, const, or let. Comment should be a sentence and outside the if-statement. http://codereview.chromium.org/7824038/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/7824038/diff/1/src/hydrogen.cc#newcode3138 src/hydrogen.cc:3138: GlobalPropertyAccess type = LookupGlobalProperty(variable, &lookup, false); Long line. http://codereview.chromium.org/7824038/diff/1/src/hydrogen.cc#newcode3637 src/hydrogen.cc:3637: Bailout("assignment to parameter, function uses arguments object"); Long line. http://codereview.chromium.org/7824038/diff/1/src/hydrogen.cc#newcode4929 src/hydrogen.cc:4929: // FIXME. Is this a TODO? http://codereview.chromium.org/7824038/diff/1/src/variables.h File src/variables.h (right): http://codereview.chromium.org/7824038/diff/1/src/variables.h#newcode182 src/variables.h:182: Location location_; Suggestion for improvement: Compress these three enums into one 32-bit integer. http://codereview.chromium.org/7824038/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
