http://codereview.chromium.org/7824038/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right):
http://codereview.chromium.org/7824038/diff/1/src/arm/full-codegen-arm.cc#newcode1816 src/arm/full-codegen-arm.cc:1816: // Global var, const, or let. On 2011/09/06 09:34:22, fschneider wrote:
Comment should be a sentence and outside the if-statement.
I thought it was pretty clear that there was an implied subject. I'll make it wordier. It definitely shouldn't be outside the if. http://codereview.chromium.org/7824038/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/7824038/diff/1/src/hydrogen.cc#newcode4929 src/hydrogen.cc:4929: // FIXME. On 2011/09/06 09:34:22, fschneider wrote:
Is this a TODO?
Oops. It was a TODO, but it's been fixed and I didn't delete the comment. http://codereview.chromium.org/7824038/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
