On Thu, Sep 8, 2011 at 19:29, <[email protected]> wrote: > Reviewers: Vitaly Repeshko, > > Description: > Rename SmartPointer to SmartArrayPointer. > > As pointed out in: http://codereview.chromium.org/7754007/#msg5 > > "SmartPointer should have been named SmartArrayPointer as it expects an > input > allocated using new[] and deallocates it using delete[]. Using it as a > simple > scoped pointer for a single object is incorrect." > > [email protected] > > Signed-off-by: Thiago Farina <[email protected]> > > > Please review this at http://codereview.chromium.org/7852002/ > > SVN Base: git://github.com/v8/v8.git@trunk >
A quick question -- why are you making this change against trunk? Should be bleeding_edge (or master). > Affected files: > M src/arm/lithium-arm.cc > M src/arm/lithium-codegen-arm.cc > M src/ast.h > M src/ast.cc > M src/code-stubs.h > M src/code-stubs.cc > M src/d8-debug.h > M src/d8-debug.cc > M src/d8-readline.cc > M src/d8.h > M src/d8.cc > M src/debug-agent.h > M src/debug-agent.cc > M src/disassembler.cc > M src/flags.cc > M src/gdb-jit.cc > M src/hydrogen-instructions.cc > M src/hydrogen.cc > M src/ia32/lithium-codegen-ia32.cc > M src/ia32/lithium-ia32.cc > M src/liveobjectlist.cc > M src/log-utils.cc > M src/log.cc > M src/messages.h > M src/messages.cc > M src/objects.h > M src/objects.cc > M src/parser.cc > M src/platform-win32.cc > M src/prettyprinter.cc > M src/runtime.cc > M src/scopes.cc > A + src/smart-array-pointer.h > D src/smart-pointer.h > M src/string-stream.h > M src/string-stream.cc > M src/x64/lithium-codegen-x64.cc > src/x64/lithium-x64.cc > M test/cctest/test-debug.cc > M test/cctest/test-func-name-inference.cc > M test/cctest/test-heap-profiler.cc > M test/cctest/test-parsing.cc > M test/cctest/test-regexp.cc > M test/cctest/test-reloc-info.cc > M tools/gyp/v8.gyp > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
