OK, LGTM. I have a few comments on the comments that you might incorporate.
http://codereview.chromium.org/7811015/diff/5001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7811015/diff/5001/src/runtime.cc#newcode1395 src/runtime.cc:1395: JSObject* real_holder = JSObject::cast(object); This code is still a bit confusing. I suggest renaming "real_holder" to "raw_holder" (I'm not sure what makes it more real than the handle version). http://codereview.chromium.org/7811015/diff/5001/src/runtime.cc#newcode1401 src/runtime.cc:1401: real_holder = *holder; And I think this line just needs a short comment that says something like, 'Update the raw pointer in case it's changed due to GC.' Otherwise, it's easy to miss this line. http://codereview.chromium.org/7811015/diff/5001/src/runtime.cc#newcode1415 src/runtime.cc:1415: global = isolate->context()->global(); Also a comment here that says something like 'Reload global in case the loop above performed a GC.' http://codereview.chromium.org/7811015/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
