Comments addressed, landing.
http://codereview.chromium.org/7811015/diff/5001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7811015/diff/5001/src/runtime.cc#newcode1395 src/runtime.cc:1395: JSObject* real_holder = JSObject::cast(object); On 2011/09/13 11:09:15, Kevin Millikin wrote:
This code is still a bit confusing. I suggest renaming "real_holder"
to
"raw_holder" (I'm not sure what makes it more real than the handle
version). Done. http://codereview.chromium.org/7811015/diff/5001/src/runtime.cc#newcode1401 src/runtime.cc:1401: real_holder = *holder; On 2011/09/13 11:09:15, Kevin Millikin wrote:
And I think this line just needs a short comment that says something
like,
'Update the raw pointer in case it's changed due to GC.'
Otherwise, it's easy to miss this line.
Done. http://codereview.chromium.org/7811015/diff/5001/src/runtime.cc#newcode1415 src/runtime.cc:1415: global = isolate->context()->global(); On 2011/09/13 11:09:15, Kevin Millikin wrote:
Also a comment here that says something like 'Reload global in case
the loop
above performed a GC.'
Done. http://codereview.chromium.org/7811015/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
