Addressed style comments.
http://codereview.chromium.org/7991007/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
http://codereview.chromium.org/7991007/diff/1/test/cctest/test-api.cc#newcode1307
test/cctest/test-api.cc:1307: const AccessorInfo& info) {
On 2011/09/26 08:45:10, Rico wrote:
indention
Done.
http://codereview.chromium.org/7991007/diff/1/test/cctest/test-api.cc#newcode1313
test/cctest/test-api.cc:1313: const AccessorInfo& info) {
On 2011/09/26 08:45:10, Rico wrote:
indention and put value on seperate line
Done.
http://codereview.chromium.org/7991007/diff/1/test/cctest/test-api.cc#newcode1319
test/cctest/test-api.cc:1319: const AccessorInfo& info) {
On 2011/09/26 08:45:10, Rico wrote:
indention
Done.
http://codereview.chromium.org/7991007/diff/1/test/cctest/test-api.cc#newcode1331
test/cctest/test-api.cc:1331: // intercept names that start with
'interceptor_'
On 2011/09/26 08:45:10, Rico wrote:
Capitalize I at start of comment
Done.
http://codereview.chromium.org/7991007/diff/1/test/cctest/test-api.cc#newcode1331
test/cctest/test-api.cc:1331: // intercept names that start with
'interceptor_'
On 2011/09/26 08:45:10, Rico wrote:
Capitalize I at start of comment
Done.
http://codereview.chromium.org/7991007/diff/1/test/cctest/test-api.cc#newcode1336
test/cctest/test-api.cc:1336: for (i = 0; name_str[i] && prefix[i]; ++i)
On 2011/09/26 08:45:10, Rico wrote:
Please add {} around body when not on single line
Done.
http://codereview.chromium.org/7991007/diff/1/test/cctest/test-api.cc#newcode1345
test/cctest/test-api.cc:1345: // intercept accesses that set certain
integer values
On 2011/09/26 08:45:10, Rico wrote:
Capital I at start of comment, period at the end
Done.
http://codereview.chromium.org/7991007/diff/1/test/cctest/test-api.cc#newcode1362
test/cctest/test-api.cc:1362: v8::NamedPropertyGetter getter,
On 2011/09/26 08:45:10, Rico wrote:
Indention
Done.
http://codereview.chromium.org/7991007/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
