Addressed feedback, landing.
http://codereview.chromium.org/7991007/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/7991007/diff/1/src/objects.cc#newcode1666 src/objects.cc:1666: &found, strict_mode); On 2011/09/26 13:52:07, Vyacheslav Egorov wrote:
We usually use one-arguments-per-line formatting for calls that do not
fit onto
one line.
Done. http://codereview.chromium.org/7991007/diff/1/src/objects.cc#newcode1667 src/objects.cc:1667: if (found) return result_object; On 2011/09/26 13:52:07, Vyacheslav Egorov wrote:
Some compilers will complain that found can be uninitialized here.
Please add
initializer to the variable.
Done. http://codereview.chromium.org/7991007/diff/1/src/objects.cc#newcode2587 src/objects.cc:2587: result_object = SetPropertyInPrototypes(name, value, attributes, On 2011/09/26 13:52:07, Vyacheslav Egorov wrote:
ditto
Done. http://codereview.chromium.org/7991007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
