Revision: 9514 Author: [email protected] Date: Tue Oct 4 05:17:08 2011 Log: Simplify compares in KeyedStoreIC::GenerateGeneric.
Review URL: http://codereview.chromium.org/8068024 http://code.google.com/p/v8/source/detail?r=9514 Modified: /branches/bleeding_edge/src/arm/ic-arm.cc /branches/bleeding_edge/src/ia32/ic-ia32.cc /branches/bleeding_edge/src/x64/ic-x64.cc ======================================= --- /branches/bleeding_edge/src/arm/ic-arm.cc Mon Sep 26 00:36:44 2011 +++ /branches/bleeding_edge/src/arm/ic-arm.cc Tue Oct 4 05:17:08 2011 @@ -1297,12 +1297,8 @@ __ cmp(r4, Operand(JS_ARRAY_TYPE)); __ b(eq, &array); // Check that the object is some kind of JSObject. - __ cmp(r4, Operand(FIRST_JS_RECEIVER_TYPE)); + __ cmp(r4, Operand(FIRST_JS_OBJECT_TYPE)); __ b(lt, &slow); - __ cmp(r4, Operand(JS_PROXY_TYPE)); - __ b(eq, &slow); - __ cmp(r4, Operand(JS_FUNCTION_PROXY_TYPE)); - __ b(eq, &slow); // Object case: Check key against length in the elements array. __ ldr(elements, FieldMemOperand(receiver, JSObject::kElementsOffset)); ======================================= --- /branches/bleeding_edge/src/ia32/ic-ia32.cc Mon Oct 3 04:44:39 2011 +++ /branches/bleeding_edge/src/ia32/ic-ia32.cc Tue Oct 4 05:17:08 2011 @@ -752,12 +752,8 @@ __ CmpInstanceType(edi, JS_ARRAY_TYPE); __ j(equal, &array); // Check that the object is some kind of JSObject. - __ CmpInstanceType(edi, FIRST_JS_RECEIVER_TYPE); + __ CmpInstanceType(edi, FIRST_JS_OBJECT_TYPE); __ j(below, &slow); - __ CmpInstanceType(edi, JS_PROXY_TYPE); - __ j(equal, &slow); - __ CmpInstanceType(edi, JS_FUNCTION_PROXY_TYPE); - __ j(equal, &slow); // Object case: Check key against length in the elements array. // eax: value ======================================= --- /branches/bleeding_edge/src/x64/ic-x64.cc Thu Sep 29 07:08:21 2011 +++ /branches/bleeding_edge/src/x64/ic-x64.cc Tue Oct 4 05:17:08 2011 @@ -626,12 +626,8 @@ __ CmpInstanceType(r9, JS_ARRAY_TYPE); __ j(equal, &array); // Check that the object is some kind of JSObject. - __ CmpInstanceType(r9, FIRST_JS_RECEIVER_TYPE); + __ CmpInstanceType(r9, FIRST_JS_OBJECT_TYPE); __ j(below, &slow); - __ CmpInstanceType(r9, JS_PROXY_TYPE); - __ j(equal, &slow); - __ CmpInstanceType(r9, JS_FUNCTION_PROXY_TYPE); - __ j(equal, &slow); // Object case: Check key against length in the elements array. // rax: value -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
