LGTM with nits if you get Slava's OK on the GC code.
http://codereview.chromium.org/8166017/diff/15001/src/ic.cc File src/ic.cc (right): http://codereview.chromium.org/8166017/diff/15001/src/ic.cc#newcode1656 src/ic.cc:1656: if (stub_kind > STORE_NO_TRANSITION) { For clarity, maybe factor out the following code into ConstructPolymorphicStub and ConstructPolymorphicStubWithTransition? http://codereview.chromium.org/8166017/diff/15001/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/8166017/diff/15001/src/objects.cc#newcode6724 src/objects.cc:6724: bool allow_overwriting_maps) { I'm not sure I like passing this bool for just debugging purposes. http://codereview.chromium.org/8166017/diff/15001/src/x64/stub-cache-x64.cc File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/8166017/diff/15001/src/x64/stub-cache-x64.cc#newcode2656 src/x64/stub-cache-x64.cc:2656: return GetCode(NORMAL, NULL); MEGAMORPHIC? http://codereview.chromium.org/8166017/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
