Danno: please take another look.
Slava: You're off the hook, as I've removed the now-obsolete GC-related
changes
again. Of course, feel free to take a look nevertheless if you wish :-)
http://codereview.chromium.org/8166017/diff/15001/src/ic.cc
File src/ic.cc (right):
http://codereview.chromium.org/8166017/diff/15001/src/ic.cc#newcode1656
src/ic.cc:1656: if (stub_kind > STORE_NO_TRANSITION) {
On 2011/10/10 13:15:12, danno wrote:
For clarity, maybe factor out the following code into
ConstructPolymorphicStub
and ConstructPolymorphicStubWithTransition?
Done. Called them "Compute..." to match the monomorphic methods.
http://codereview.chromium.org/8166017/diff/15001/src/objects.cc
File src/objects.cc (right):
http://codereview.chromium.org/8166017/diff/15001/src/objects.cc#newcode6724
src/objects.cc:6724: bool allow_overwriting_maps) {
On 2011/10/10 13:15:12, danno wrote:
I'm not sure I like passing this bool for just debugging purposes.
Done.
http://codereview.chromium.org/8166017/diff/15001/src/objects.cc#newcode6758
src/objects.cc:6758: Map* target = reinterpret_cast<Map*>(object);
On 2011/10/10 14:02:59, Vyacheslav Egorov wrote:
My suggestion: instead of glue-ing together two transitions SMI ->
DOUBLE ->
FAST, SMI -> FAST and making transitions graph into a dag (instead of
tree) lets
consider always creating SMI -> DOUBLE -> FAST chain when
transitioning from SMI
to FAST.
That would waste some space (minuscule amount) but will simplify the
system and
keep transition graph a tree (which means this code will not be needed
and
reasoning about tree is always simpler).
Done.
http://codereview.chromium.org/8166017/diff/15001/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):
http://codereview.chromium.org/8166017/diff/15001/src/x64/stub-cache-x64.cc#newcode2656
src/x64/stub-cache-x64.cc:2656: return GetCode(NORMAL, NULL);
On 2011/10/10 13:15:12, danno wrote:
MEGAMORPHIC?
Done, also for ARM.
http://codereview.chromium.org/8166017/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
