LGTM with comments addressed.
http://codereview.chromium.org/8271007/diff/1001/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/8271007/diff/1001/src/x64/code-stubs-x64.cc#newcode6006 src/x64/code-stubs-x64.cc:6006: __ jmp(&gc_required); lolwut? http://codereview.chromium.org/8271007/diff/1001/src/x64/code-stubs-x64.cc#newcode6016 src/x64/code-stubs-x64.cc:6016: // r11: destination FixedArray Please move this up to after the AllocateInNewSpace line (where r11 gets set). http://codereview.chromium.org/8271007/diff/1001/src/x64/code-stubs-x64.cc#newcode6040 src/x64/code-stubs-x64.cc:6040: __ movq(FieldOperand(r11, r9, times_8, FixedDoubleArray::kHeaderSize), r12); FixedArray::kHeaderSize (I know they're the same, but still). Also, I think times_pointer_size would be clearer than times_8. http://codereview.chromium.org/8271007/diff/1001/src/x64/code-stubs-x64.cc#newcode6052 src/x64/code-stubs-x64.cc:6052: __ movq(FieldOperand(r11, r9, times_8, FixedDoubleArray::kHeaderSize), rdi); times_pointer_size, FixedArray::kHeaderSize http://codereview.chromium.org/8271007/diff/1001/src/x64/code-stubs-x64.cc#newcode6070 src/x64/code-stubs-x64.cc:6070: HeapObject::kMapOffset, JSObject::kElementsOffset! http://codereview.chromium.org/8271007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
