Please take another look. Issue v8:1767 seems to be unrelated to this CL
since
it reproduces on bleeding_edge. I'll take a look at that problem
independently
from this.
http://codereview.chromium.org/8271007/diff/1001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
http://codereview.chromium.org/8271007/diff/1001/src/x64/code-stubs-x64.cc#newcode6006
src/x64/code-stubs-x64.cc:6006: __ jmp(&gc_required);
On 2011/10/14 09:25:38, Jakob wrote:
lolwut?
Forgot to take this out after some debugging.
http://codereview.chromium.org/8271007/diff/1001/src/x64/code-stubs-x64.cc#newcode6016
src/x64/code-stubs-x64.cc:6016: // r11: destination FixedArray
On 2011/10/14 09:25:38, Jakob wrote:
Please move this up to after the AllocateInNewSpace line (where r11
gets set).
Done.
http://codereview.chromium.org/8271007/diff/1001/src/x64/code-stubs-x64.cc#newcode6040
src/x64/code-stubs-x64.cc:6040: __ movq(FieldOperand(r11, r9, times_8,
FixedDoubleArray::kHeaderSize), r12);
On 2011/10/14 09:25:38, Jakob wrote:
FixedArray::kHeaderSize (I know they're the same, but still). Also, I
think
times_pointer_size would be clearer than times_8.
Done.
http://codereview.chromium.org/8271007/diff/1001/src/x64/code-stubs-x64.cc#newcode6052
src/x64/code-stubs-x64.cc:6052: __ movq(FieldOperand(r11, r9, times_8,
FixedDoubleArray::kHeaderSize), rdi);
On 2011/10/14 09:25:38, Jakob wrote:
times_pointer_size, FixedArray::kHeaderSize
Done.
http://codereview.chromium.org/8271007/diff/1001/src/x64/code-stubs-x64.cc#newcode6070
src/x64/code-stubs-x64.cc:6070: HeapObject::kMapOffset,
On 2011/10/14 09:25:38, Jakob wrote:
JSObject::kElementsOffset!
Done.
http://codereview.chromium.org/8271007/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
