I looked at all but the lithium-mips.{h,cc} and lithium-codegen-mips.{h,cc}
files. The rest seems OK to me.
http://codereview.chromium.org/7934002/diff/15001/src/SConscript
File src/SConscript (right):
http://codereview.chromium.org/7934002/diff/15001/src/SConscript#newcode175
src/SConscript:175: mips/lithium-mips.cc
It's not really very important, but I guess we alphabetize these ('M-x
sort-lines' in emacs), codegen, gap-resolver, mips.
http://codereview.chromium.org/7934002/diff/15001/src/mips/lithium-gap-resolver-mips.cc
File src/mips/lithium-gap-resolver-mips.cc (right):
http://codereview.chromium.org/7934002/diff/15001/src/mips/lithium-gap-resolver-mips.cc#newcode40
src/mips/lithium-gap-resolver-mips.cc:40: : cgen_(owner), moves_(32),
root_index_(0), in_cycle_(false),
We normally put one initializer per line if they don't all fit on the
same line.
http://codereview.chromium.org/7934002/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
