Kevin, I updated for the comments you left. I was not able to rebase this on
today's activity yet, as I have a couple bugs in the ported commits. I'll
get it
in as soon as I can, but will likely be after your end of day tomorrow.
thanks,
paul
http://codereview.chromium.org/7934002/diff/15001/src/SConscript
File src/SConscript (right):
http://codereview.chromium.org/7934002/diff/15001/src/SConscript#newcode175
src/SConscript:175: mips/lithium-mips.cc
On 2011/10/19 07:43:21, Kevin Millikin wrote:
It's not really very important, but I guess we alphabetize these ('M-x
sort-lines' in emacs), codegen, gap-resolver, mips.
Done. I suppose maybe we should then move the entire arch:mips section
below arch:ia32 for same reason, but I did not do that here. Let me know
if you want that also.
http://codereview.chromium.org/7934002/diff/15001/src/mips/lithium-gap-resolver-mips.cc
File src/mips/lithium-gap-resolver-mips.cc (right):
http://codereview.chromium.org/7934002/diff/15001/src/mips/lithium-gap-resolver-mips.cc#newcode40
src/mips/lithium-gap-resolver-mips.cc:40: : cgen_(owner), moves_(32),
root_index_(0), in_cycle_(false),
On 2011/10/19 07:43:21, Kevin Millikin wrote:
We normally put one initializer per line if they don't all fit on the
same line.
Done.
http://codereview.chromium.org/7934002/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
