LGTM
http://codereview.chromium.org/8345039/diff/5001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/8345039/diff/5001/src/runtime.cc#newcode12973 src/runtime.cc:12973: if (!raw_fun->IsJSFunction()) well you added them above, so how about a pair of {} here as well http://codereview.chromium.org/8345039/diff/5001/src/runtime.cc#newcode12984 src/runtime.cc:12984: // The --builtins-in-stack-traces command line flag allows including --builtins-in-stack-traces -> --builtins-in-stack-trace http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2.js File test/mjsunit/stack-traces-2.js (right): http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2.js#newcode1 test/mjsunit/stack-traces-2.js:1: // Copyright 2009 the V8 project authors. All rights reserved. 2011 http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2.js#newcode80 test/mjsunit/stack-traces-2.js:80: // Omitted because QuickSort has builtins object as receiver, and is non-native Comment is slightly misleading, it is not omitted in this case due to the flag http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2.js#newcode83 test/mjsunit/stack-traces-2.js:83: (b < a) - (a < b); }); indention seems off here http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2.js#newcode86 test/mjsunit/stack-traces-2.js:86: // Omitted because ADD from runtime.js is non-native builtin. Also slightly misleading http://codereview.chromium.org/8345039/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
