http://codereview.chromium.org/8345039/diff/5001/src/runtime.cc File src/runtime.cc (right):
http://codereview.chromium.org/8345039/diff/5001/src/runtime.cc#newcode12973 src/runtime.cc:12973: if (!raw_fun->IsJSFunction()) Absolutely. http://codereview.chromium.org/8345039/diff/5001/src/runtime.cc#newcode12984 src/runtime.cc:12984: // The --builtins-in-stack-traces command line flag allows including I'm renaming it to -trace*s*. I've misspelled it consistently every time I've written it, so with the 's' seems to be the most obvious name. http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2.js File test/mjsunit/stack-traces-2.js (right): http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2.js#newcode80 test/mjsunit/stack-traces-2.js:80: // Omitted because QuickSort has builtins object as receiver, and is non-native On 2011/10/20 12:17:33, Rico wrote:
Comment is slightly misleading, it is not omitted in this case due to
the flag Done. http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2.js#newcode83 test/mjsunit/stack-traces-2.js:83: (b < a) - (a < b); }); Off by a "Not". Fixed. http://codereview.chromium.org/8345039/diff/5001/test/mjsunit/stack-traces-2.js#newcode86 test/mjsunit/stack-traces-2.js:86: // Omitted because ADD from runtime.js is non-native builtin. On 2011/10/20 12:17:33, Rico wrote:
Also slightly misleading
Done. http://codereview.chromium.org/8345039/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
