LGTM, but got one question.
http://codereview.chromium.org/8366031/diff/1006/src/mips/codegen-mips.cc File src/mips/codegen-mips.cc (right): http://codereview.chromium.org/8366031/diff/1006/src/mips/codegen-mips.cc#newcode79 src/mips/codegen-mips.cc:79: __ mov(v0, a0); Why is a0 moved to v0? KeyedStoreStubCompiler::GenerateStoreFastElement that follows expects value in a0 as well. In the case that the generator is called from crankshaft, no value or key exist in the first place. http://codereview.chromium.org/8366031/diff/1006/src/mips/codegen-mips.cc#newcode200 src/mips/codegen-mips.cc:200: __ mov(v0, a0); Ditto. http://codereview.chromium.org/8366031/diff/1006/src/mips/codegen-mips.cc#newcode311 src/mips/codegen-mips.cc:311: __ mov(v0, a0); Ditto. http://codereview.chromium.org/8366031/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
