On 2011/10/21 16:39:49, Paul Lind wrote:
Hi Yang, thanks for catching those extra reg-moves. They are gone now.
thanks,
paul
http://codereview.chromium.org/8366031/diff/1006/src/mips/codegen-mips.cc
File src/mips/codegen-mips.cc (right):
http://codereview.chromium.org/8366031/diff/1006/src/mips/codegen-mips.cc#newcode79
src/mips/codegen-mips.cc:79: __ mov(v0, a0);
On 2011/10/21 07:43:34, Yang wrote:
> Why is a0 moved to v0?
> KeyedStoreStubCompiler::GenerateStoreFastElement that follows expects
value
in
> a0 as well.
> In the case that the generator is called from crankshaft, no value or
key
exist
> in the first place.
Yep, you are correct, it is not needed here. Removed.
This is a common pattern for mips, needed in lots of places, and we just
found/fixed a bug where this was needed in porting
FastElementsConversionStub
earlier in this commit. So here I guess we errored in the other direction.
http://codereview.chromium.org/8366031/diff/1006/src/mips/codegen-mips.cc#newcode200
src/mips/codegen-mips.cc:200: __ mov(v0, a0);
On 2011/10/21 07:43:34, Yang wrote:
> Ditto.
Removed.
http://codereview.chromium.org/8366031/diff/1006/src/mips/codegen-mips.cc#newcode311
src/mips/codegen-mips.cc:311: __ mov(v0, a0);
On 2011/10/21 07:43:34, Yang wrote:
> Ditto.
Removed.
LGTM, landing.
http://codereview.chromium.org/8366031/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
