lgtm with comments addressed. please address the comments and I will land.
http://codereview.chromium.org/8373029/diff/8001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/8373029/diff/8001/src/hydrogen.cc#newcode2693 src/hydrogen.cc:2693: SwitchType switch_type = UNSUPPORTED_SWITCH; UNSUPPORTED -> UNKNOWN? http://codereview.chromium.org/8373029/diff/8001/src/hydrogen.cc#newcode2708 src/hydrogen.cc:2708: } else if (clause->label()->IsSmiLiteral() && labels can be neither smi nor strings. Correct condition would be: (switch_type == STRING_SWITCH && !clause->label()->IsStringLiteral()) || (switch_type == SMI_SWITCH && !clause->label()->IsSmiLiteral()) http://codereview.chromium.org/8373029/diff/8001/src/hydrogen.cc#newcode2718 src/hydrogen.cc:2718: AddInstruction(HCheckInstanceType::NewIsSymbol(tag_value)); You also need HCheckNonSmi(tag_value) otherwise it IsSymbolCheck will segfault when you have a smi as a tag value http://codereview.chromium.org/8373029/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
