additional comment.

I'll fix it myself and also add tests before landing.


http://codereview.chromium.org/8373029/diff/11001/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/8373029/diff/11001/src/hydrogen.cc#newcode2719
src/hydrogen.cc:2719: AddInstruction(new(zone())
HCheckNonSmi(tag_value));
Checking that tag_value is non-smi after is-symbol already segfaulted is
not very helpful.

Usually you want to check for something before you segfault.

http://codereview.chromium.org/8373029/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to