lgtm
http://codereview.chromium.org/8332003/diff/2001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/8332003/diff/2001/src/arm/code-stubs-arm.cc#newcode6680 src/arm/code-stubs-arm.cc:6680: void StringDictionaryLookupStub::GenerateNegativeLookup(MacroAssembler* masm, On 2011/10/24 15:55:12, Kevin Millikin wrote:
Cannot be wrapped with retry after GC, because it assembles before
trying
allocation.
You can use create stub in the beginning of the function and call GetCode if you want to ensure that it is created but no assembly is emitted. http://codereview.chromium.org/8332003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
