LGTM with comments.
http://codereview.chromium.org/8332003/diff/2001/src/x64/stub-cache-x64.cc File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/8332003/diff/2001/src/x64/stub-cache-x64.cc#newcode86 src/x64/stub-cache-x64.cc:86: Label* miss_label, Indentation is broken. http://codereview.chromium.org/8332003/diff/2001/src/x64/stub-cache-x64.cc#newcode1199 src/x64/stub-cache-x64.cc:1199: if (result->IsFailure()) set_failure(Failure::cast(result)); The result can be NULL. It works but looks suspicious. :) http://codereview.chromium.org/8332003/diff/2001/src/x64/stub-cache-x64.cc#newcode1604 src/x64/stub-cache-x64.cc:1604: __ bind(&miss);GenerateMissBranch(); New line between statements. http://codereview.chromium.org/8332003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
