LGTM.
http://codereview.chromium.org/8383033/diff/1/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/8383033/diff/1/src/arm/stub-cache-arm.cc#newcode530 src/arm/stub-cache-arm.cc:530: : masm->isolate()->builtins()->KeyedLoadIC_Miss(); We usually just indent this with the regular four space indent: Handle<Code> code = (kind == Code::LOAD_IC) ? masm->isolate()->builtins()->LoadIC_Miss() : masm->isolate()->builtins()->KeyedLoadIC_Miss(); Otherwise it wastes too much of our 80 columns. http://codereview.chromium.org/8383033/diff/1/src/arm/stub-cache-arm.cc#newcode3077 src/arm/stub-cache-arm.cc:3077: return GetCode(CALLBACKS, name); It might be a good idea (just to help us keep stuff straight) to rename the raw pointer version of this function to TryGetCode. http://codereview.chromium.org/8383033/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
