Addressed comments, landing.
http://codereview.chromium.org/8383033/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/8383033/diff/1/src/arm/stub-cache-arm.cc#newcode530
src/arm/stub-cache-arm.cc:530: :
masm->isolate()->builtins()->KeyedLoadIC_Miss();
On 2011/10/25 11:35:50, Kevin Millikin wrote:
We usually just indent this with the regular four space indent:
Handle<Code> code = (kind == Code::LOAD_IC)
? masm->isolate()->builtins()->LoadIC_Miss()
: masm->isolate()->builtins()->KeyedLoadIC_Miss();
Otherwise it wastes too much of our 80 columns.
Done.
http://codereview.chromium.org/8383033/diff/1/src/arm/stub-cache-arm.cc#newcode3077
src/arm/stub-cache-arm.cc:3077: return GetCode(CALLBACKS, name);
On 2011/10/25 11:35:50, Kevin Millikin wrote:
It might be a good idea (just to help us keep stuff straight) to
rename the raw
pointer version of this function to TryGetCode.
Done.
http://codereview.chromium.org/8383033/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
