lgtm
http://codereview.chromium.org/8390047/diff/1/test/cctest/test-dictionary.cc File test/cctest/test-dictionary.cc (right): http://codereview.chromium.org/8390047/diff/1/test/cctest/test-dictionary.cc#newcode79 test/cctest/test-dictionary.cc:79: CHECK_NE(key->GetIdentityHash(OMIT_CREATION), HEAP->undefined_value()); Why not check for isSmi? http://codereview.chromium.org/8390047/diff/1/test/cctest/test-dictionary.cc#newcode87 test/cctest/test-dictionary.cc:87: CHECK_NE(key->GetIdentityHash(OMIT_CREATION), HEAP->undefined_value()); Same here. http://codereview.chromium.org/8390047/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
