[v8-dev] Re: Fix identity hash code function to respect flag. (issue 8390047)

[mstarzinger]

Added new patch set. Landed.


http://codereview.chromium.org/8390047/diff/1/test/cctest/test-dictionary.cc
File test/cctest/test-dictionary.cc (right):

http://codereview.chromium.org/8390047/diff/1/test/cctest/test-dictionary.cc#newcode79
test/cctest/test-dictionary.cc:79:
CHECK_NE(key->GetIdentityHash(OMIT_CREATION), HEAP->undefined_value());
On 2011/10/26 12:19:48, rossberg wrote:

Why not check for isSmi?

Done.

http://codereview.chromium.org/8390047/diff/1/test/cctest/test-dictionary.cc#newcode87
test/cctest/test-dictionary.cc:87:
CHECK_NE(key->GetIdentityHash(OMIT_CREATION), HEAP->undefined_value());
On 2011/10/26 12:19:48, rossberg wrote:

Same here.

Done.

http://codereview.chromium.org/8390047/

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev