lgtm
Drive by.
This is awesome. I can't wait for this to hit Chromium.
Is there an open bug about enumeration? I guess that is pretty far off due
to
its long tail of dependencies.
http://codereview.chromium.org/8372027/diff/3024/src/objects.h
File src/objects.h (right):
http://codereview.chromium.org/8372027/diff/3024/src/objects.h#newcode7022
src/objects.h:7022: // The JSSet describes EcmaScript Harmony maps
nit
// The JSSet describes EcmaScript Harmony *sets*
http://codereview.chromium.org/8372027/diff/3024/test/mjsunit/harmony/collections.js
File test/mjsunit/harmony/collections.js (right):
http://codereview.chromium.org/8372027/diff/3024/test/mjsunit/harmony/collections.js#newcode72
test/mjsunit/harmony/collections.js:72: for (i = 0; i < 20; i++) {
missing var
http://codereview.chromium.org/8372027/diff/3024/test/mjsunit/harmony/collections.js#newcode102
test/mjsunit/harmony/collections.js:102: var keys = [ +0, -0, +Infinity,
-Infinity, true, false ];
is it worth testing NaN, undefined and null too?
http://codereview.chromium.org/8372027/diff/3024/test/mjsunit/harmony/collections.js#newcode187
test/mjsunit/harmony/collections.js:187: for (i = 0; i < 20; i++) {
var
http://codereview.chromium.org/8372027/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
