Thanks for the drive-by!
http://codereview.chromium.org/8372027/diff/3024/src/objects.h File src/objects.h (right): http://codereview.chromium.org/8372027/diff/3024/src/objects.h#newcode7022 src/objects.h:7022: // The JSSet describes EcmaScript Harmony maps On 2011/10/26 17:09:44, arv wrote:
nit
// The JSSet describes EcmaScript Harmony *sets*
Done (will include in next CL). http://codereview.chromium.org/8372027/diff/3024/test/mjsunit/harmony/collections.js File test/mjsunit/harmony/collections.js (right): http://codereview.chromium.org/8372027/diff/3024/test/mjsunit/harmony/collections.js#newcode72 test/mjsunit/harmony/collections.js:72: for (i = 0; i < 20; i++) { On 2011/10/26 17:09:44, arv wrote:
missing var
Done (will include in next CL). http://codereview.chromium.org/8372027/diff/3024/test/mjsunit/harmony/collections.js#newcode102 test/mjsunit/harmony/collections.js:102: var keys = [ +0, -0, +Infinity, -Infinity, true, false ]; On 2011/10/26 17:09:44, arv wrote:
is it worth testing NaN, undefined and null too?
Currently "undefined" and "null" cannot be used as keys to Maps, I am working on that. The test for correct "NaN" handling is further down at line 203. http://codereview.chromium.org/8372027/diff/3024/test/mjsunit/harmony/collections.js#newcode187 test/mjsunit/harmony/collections.js:187: for (i = 0; i < 20; i++) { On 2011/10/26 17:09:44, arv wrote:
var
Done (will include in next CL). http://codereview.chromium.org/8372027/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
