LGTM
http://codereview.chromium.org/8343054/diff/1/src/v8natives.js File src/v8natives.js (right): http://codereview.chromium.org/8343054/diff/1/src/v8natives.js#newcode174 src/v8natives.js:174: throw new $EvalError('The "this" value passed to eval must ' + is object->value intentional, will this make us better compatible with JSC? http://codereview.chromium.org/8343054/diff/1/test/mjsunit/eval.js File test/mjsunit/eval.js (right): http://codereview.chromium.org/8343054/diff/1/test/mjsunit/eval.js#newcode161 test/mjsunit/eval.js:161: var obj1 = { f: function(eval) { return eval("this"); } }; Why the rename to obj1 (and obj2 below) http://codereview.chromium.org/8343054/diff/1/test/mjsunit/regress/regress-221.js File test/mjsunit/regress/regress-221.js (right): http://codereview.chromium.org/8343054/diff/1/test/mjsunit/regress/regress-221.js#newcode33 test/mjsunit/regress/regress-221.js:33: assertThrows('for(;;) eval("delete eval");'); if we actually do not throw this will be a timout, not an error (since we will run forever) http://codereview.chromium.org/8343054/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
