http://codereview.chromium.org/8343054/diff/1/src/v8natives.js File src/v8natives.js (right):
http://codereview.chromium.org/8343054/diff/1/src/v8natives.js#newcode174 src/v8natives.js:174: throw new $EvalError('The "this" value passed to eval must ' + Yes and yes. The message is bogus now, since that's not what we are checking (but that was always the case for a detached global). http://codereview.chromium.org/8343054/diff/1/test/mjsunit/eval.js File test/mjsunit/eval.js (right): http://codereview.chromium.org/8343054/diff/1/test/mjsunit/eval.js#newcode161 test/mjsunit/eval.js:161: var obj1 = { f: function(eval) { return eval("this"); } }; Artifact of rewriting. At some point the var was outside the function. I'll just make it "obj". http://codereview.chromium.org/8343054/diff/1/test/mjsunit/regress/regress-221.js File test/mjsunit/regress/regress-221.js (right): http://codereview.chromium.org/8343054/diff/1/test/mjsunit/regress/regress-221.js#newcode33 test/mjsunit/regress/regress-221.js:33: assertThrows('for(;;) eval("delete eval");'); This test is pretty meaningless now, so I'll just remove it, instead of rewriting it to something that doesn't test the original intent anyway. http://codereview.chromium.org/8343054/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
