The error in jsuglify seems unrelated to your change. I could also reproduce it
in bleeding_edge.

I did some benchmarking and according to our measurements jslint regressed
performance by 3% with the latest patchset. We need a significant win to land
it.

For example I noticed that function "advance" now takes almost twice as long
according to profiling.


http://codereview.chromium.org/8373029/diff/37002/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/8373029/diff/37002/src/hydrogen.cc#newcode2740
src/hydrogen.cc:2740: oddball_check = new(zone())
HIsStringAndBranch(tag_value);
oddball_check is really the wrong name, I'd suggest string_check since
it tests if tag_value is a string or not.

http://codereview.chromium.org/8373029/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to