lgtm
http://codereview.chromium.org/8343056/diff/1/src/objects-inl.h File src/objects-inl.h (left): http://codereview.chromium.org/8343056/diff/1/src/objects-inl.h#oldcode4437 src/objects-inl.h:4437: ASSERT(!key->IsUndefined() && !key->IsNull()); Don't you still need the IsUndefined part of the assertion, at least for now? http://codereview.chromium.org/8343056/diff/1/src/objects-inl.h#oldcode4446 src/objects-inl.h:4446: ASSERT(!other->IsUndefined() && !other->IsNull()); Same here. http://codereview.chromium.org/8343056/diff/1/test/mjsunit/harmony/collections.js File test/mjsunit/harmony/collections.js (right): http://codereview.chromium.org/8343056/diff/1/test/mjsunit/harmony/collections.js#newcode74 test/mjsunit/harmony/collections.js:74: for (var i = 0; i < 20; i++) { Ts-ts-ts. http://codereview.chromium.org/8343056/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
