http://codereview.chromium.org/8343056/diff/1/src/objects-inl.h File src/objects-inl.h (left):
http://codereview.chromium.org/8343056/diff/1/src/objects-inl.h#oldcode4437 src/objects-inl.h:4437: ASSERT(!key->IsUndefined() && !key->IsNull()); On 2011/11/02 15:17:37, rossberg wrote:
Don't you still need the IsUndefined part of the assertion, at least
for now? This assertion is now covered by ASSERT(IsKey(key)) in the objects.cc functions. I moved it there because it catches misuse of keys earlier and even for cases where hash values are not even generated. http://codereview.chromium.org/8343056/diff/1/src/objects-inl.h#oldcode4446 src/objects-inl.h:4446: ASSERT(!other->IsUndefined() && !other->IsNull()); On 2011/11/02 15:17:37, rossberg wrote:
Same here.
Likewise. http://codereview.chromium.org/8343056/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
