Reviewers: Michael Starzinger, danno, Yang, Paul Lind,
Message:
The following comment in issue 1808 describes the situation in more detail,
other architectures seem to be affected as well:
http://code.google.com/p/v8/issues/detail?id=1808#c3
Description:
MIPS: Fixed a bug in StringHelper::GenerateTwoCharacterSymbolTableProbe.
r9871 (5baeaf57) changed the fill value for deleted entries in hash tables
from
null_value to the_hole_value.
This commit changes an assertion in MIPS code that expects this value.
BUG=
TEST=
Please review this at http://codereview.chromium.org/8479028/
Affected files:
M src/mips/code-stubs-mips.cc
Index: src/mips/code-stubs-mips.cc
diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc
index
8ff39c529aec08ec1592f0ac0d44265832d4596e..c8b8053fe3c7c731f866fb07483031513b112957
100644
--- a/src/mips/code-stubs-mips.cc
+++ b/src/mips/code-stubs-mips.cc
@@ -5788,7 +5788,7 @@ void
StringHelper::GenerateTwoCharacterSymbolTableProbe(MacroAssembler* masm,
__ Branch(not_found, eq, undefined, Operand(candidate));
// Must be null (deleted entry).
if (FLAG_debug_code) {
- __ LoadRoot(scratch, Heap::kNullValueRootIndex);
+ __ LoadRoot(scratch, Heap::kTheHoleValueRootIndex);
__ Assert(eq, "oddball in symbol table is not undefined or null",
scratch, Operand(candidate));
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
