Reviewers: Lasse Reichstein, Description: Optimize DefineOneShotAccessor in messages.js to not call DefineOwnProperty.
Please review this at http://codereview.chromium.org/8490008/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/messages.js Index: src/messages.js =================================================================== --- src/messages.js (revision 9884) +++ src/messages.js (working copy) @@ -745,12 +745,9 @@ hasBeenSet = true; value = v; } - var desc = { get: getter, - set: setter, - enumerable: false, - configurable: true }; - desc = ToPropertyDescriptor(desc); - DefineOwnProperty(obj, name, desc, true); + var flag = DONT_ENUM; + %DefineOrRedefineAccessorProperty(obj, name, GETTER, getter, flag); + %DefineOrRedefineAccessorProperty(obj, name, SETTER, setter, flag); } function CallSite(receiver, fun, pos) { -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
