LGTM with comments
http://codereview.chromium.org/8508008/diff/1/src/handles.cc File src/handles.cc (right): http://codereview.chromium.org/8508008/diff/1/src/handles.cc#newcode673 src/handles.cc:673: if (!line_number) return code_pos + script->column_offset()->value(); Please use (line_number == 0) http://codereview.chromium.org/8508008/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/8508008/diff/1/test/cctest/test-api.cc#newcode13762 test/cctest/test-api.cc:13762: env->Global()->Get(v8::String::New("bar"))); I don't get these numbers. Shouldn't the difference between them be 5? I I count they should be 13 and 18. http://codereview.chromium.org/8508008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
