On 2011/11/09 14:10:10, Yury Semikhatsky wrote:
http://codereview.chromium.org/8508008/diff/1/src/handles.cc
File src/handles.cc (right):
http://codereview.chromium.org/8508008/diff/1/src/handles.cc#newcode673
src/handles.cc:673: if (!line_number) return code_pos +
script->column_offset()->value();
On 2011/11/09 14:00:10, Søren Gjesse wrote:
> Please use (line_number == 0)
Done.
http://codereview.chromium.org/8508008/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
http://codereview.chromium.org/8508008/diff/1/test/cctest/test-api.cc#newcode13762
test/cctest/test-api.cc:13762:
env->Global()->Get(v8::String::New("bar")));
On 2011/11/09 14:00:10, Søren Gjesse wrote:
> I don't get these numbers. Shouldn't the difference between them be 5?
I I
count
> they should be 13 and 18.
I don't see why the difference between _column_ numbers in two different
lines
should be 5.
14 = 12 + 2 as function foo goes on the first line of the script and its
column
= column inside script(zero-based) + the script column.
17 is just zero based offset of the function bar on its line.
Thanks for the explanation. I missed the column offset in the script
creation
and that we use zero based offsets (even though I decided to do just that)
http://codereview.chromium.org/8508008/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
