Drive by comment.
http://codereview.chromium.org/8508052/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/8508052/diff/1/src/runtime.cc#newcode12232 src/runtime.cc:12232: // Create a function context first, than put 'with' context on top of it. This comment is wrong. http://codereview.chromium.org/8508052/diff/1/src/scopes.cc File src/scopes.cc (right): http://codereview.chromium.org/8508052/diff/1/src/scopes.cc#newcode592 src/scopes.cc:592: DeserializeScopeChain(*calling_context, global_scope); I don't like this. It doesn't seem consistent. For lazily-compiled code, we deserialize right up front in the parser, so the parser always has the correct scope chain. I think of eval code as being the same as lazy compilation, so it seems better to deserialize earlier: somewhere before Parser::DoParseProgram parses the program body, inspect the compilation info to see if it's an eval call and deserialize there. http://codereview.chromium.org/8508052/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
