http://codereview.chromium.org/8508052/diff/6020/src/scopes.cc File src/scopes.cc (right):
http://codereview.chromium.org/8508052/diff/6020/src/scopes.cc#newcode132 src/scopes.cc:132: ASSERT((type == GLOBAL_SCOPE) == (outer_scope == NULL)); On 2011/11/14 15:20:52, fschneider wrote:
Use ASSERT_EQ instead, so that you get a better error message if the
assertion
fails:
ASSERT_EQ(type == GLOBAL_SCOPE, outer_scope == NULL);
Done. http://codereview.chromium.org/8508052/diff/6020/src/scopes.cc#newcode269 src/scopes.cc:269: !top->outer_scope()->already_resolved()) { I've updated the comment with a more thorough description. On 2011/11/14 15:20:52, fschneider wrote:
This loop condition seems inconsistent with the comment.
http://codereview.chromium.org/8508052/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
