http://codereview.chromium.org/8519002/diff/5001/src/heap.h File src/heap.h (right):
http://codereview.chromium.org/8519002/diff/5001/src/heap.h#newcode1781 src/heap.h:1781: return (gc_count_ - gc_count_when_last_idle_round_finished_ > 4); On 2011/11/11 13:27:26, ulan wrote:
We agreed to count only scavenges here, but for that I need to add
another
counter and code to maintain the counter. Since full GC are rare
anyway, I think
gc_count_ is good enough until we add much better counters like
"promoted bytes
since last full GC".
I really think we should just add the extra counter here. It's only about 3 lines. You are counting scavenges to decide to do a full GC. If you count full GCs too then you risk a situation where a full GC contributes to the decision to do another full GC. That sounds like the sort of positive feedback that should be avoided on principle. http://codereview.chromium.org/8519002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
