LGTM
http://codereview.chromium.org/8519002/diff/9002/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/8519002/diff/9002/src/heap.cc#newcode4497 src/heap.cc:4497: if (mark_sweeps_since_idle_round_started_ >= kMaxMarkSweepsInIdleRound) { This test is also included in WorthStartingGCWhenIdle. Do we need it both places? http://codereview.chromium.org/8519002/diff/9002/src/heap.cc#newcode4499 src/heap.cc:4499: return true; If sweeping is not complete we should not return here. http://codereview.chromium.org/8519002/diff/9002/src/heap.cc#newcode4524 src/heap.cc:4524: if (gc_count_at_last_idle_gc_ == gc_count_) { It would be nice with a comment that explained the thinking behind this condition. http://codereview.chromium.org/8519002/diff/9002/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): http://codereview.chromium.org/8519002/diff/9002/test/cctest/test-heap.cc#newcode1320 test/cctest/test-heap.cc:1320: CHECK(new_size < old_size); I think we need more testing. There should be a test that makes sure we use the hint argument, eg. a loop that keeps calling with a hint of 10 and checks that we eventually finish GCing. http://codereview.chromium.org/8519002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
