Thanks Lasse. Ulan and I just found out by looking at GCC-compiled code of tan(). There are a few other places where "ffree(); fincstp()" could be replaced. Will be addressed in another CL though.
Yang On Fri, Nov 25, 2011 at 2:11 PM, <[email protected]> wrote: > LGTM if Lasse's comment is addressed. > > > http://codereview.chromium.**org/8700004/diff/1/src/arm/** > full-codegen-arm.cc<http://codereview.chromium.org/8700004/diff/1/src/arm/full-codegen-arm.cc> > File src/arm/full-codegen-arm.cc (right): > > http://codereview.chromium.**org/8700004/diff/1/src/arm/** > full-codegen-arm.cc#**newcode3142<http://codereview.chromium.org/8700004/diff/1/src/arm/full-codegen-arm.cc#newcode3142> > src/arm/full-codegen-arm.cc:**3142: context()->Plug(r0); > In future maybe we could define a platform-specific function > context()->PlugResultRegister(**) and then move all the other code to > platform-independent code? > > http://codereview.chromium.**org/8700004/<http://codereview.chromium.org/8700004/> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
