http://codereview.chromium.org/8688007/diff/1/src/ast.h File src/ast.h (right):
http://codereview.chromium.org/8688007/diff/1/src/ast.h#newcode1157 src/ast.h:1157: bool IsUsedAsLValue() { On 2011/11/30 16:11:46, fschneider wrote:
Maybe rename to just IsLValue?
Done. http://codereview.chromium.org/8688007/diff/1/src/ast.h#newcode1167 src/ast.h:1167: void MarkAsUsedAsLValue() { is_used_as_lvalue_ = true; } On 2011/11/30 16:11:46, fschneider wrote:
Rename to MarkAsLValue?
Done. http://codereview.chromium.org/8688007/diff/1/src/scopes.cc File src/scopes.cc (right): http://codereview.chromium.org/8688007/diff/1/src/scopes.cc#newcode288 src/scopes.cc:288: if (!info->is_native() && FLAG_harmony_scoping) { The test is not needed anymore, I'll remove it. It's an artifact from the time before the extended mode was introduced. There harmony scoping features where only enabled for non-native functions. On 2011/11/30 16:11:46, fschneider wrote:
Can you explain why you need to test for is_native here?
http://codereview.chromium.org/8688007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
