LGTM with comments below.
http://codereview.chromium.org/8688007/diff/6013/src/ast.h File src/ast.h (right): http://codereview.chromium.org/8688007/diff/6013/src/ast.h#newcode1179 src/ast.h:1179: bool is_lvalue_; Please make sure the instance size (sizeof) for VariableProxy is unchanged on all platforms. I think it should be fine since each bool should not occupy more than 1 bytes. But otherwise we should pack the booleans into one a one-word bitfield. http://codereview.chromium.org/8688007/diff/6013/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/8688007/diff/6013/src/parser.cc#newcode4322 src/parser.cc:4322: VariableProxy* lhs = expression != NULL Maybe rename to VariableProxy* proxy = ... http://codereview.chromium.org/8688007/diff/6013/src/scopes.cc File src/scopes.cc (right): http://codereview.chromium.org/8688007/diff/6013/src/scopes.cc#newcode591 src/scopes.cc:591: return proxy; This would fit on the line above for a single-line if-statement. http://codereview.chromium.org/8688007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
