http://codereview.chromium.org/8844002/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right):
http://codereview.chromium.org/8844002/diff/1/test/cctest/test-parsing.cc#newcode976 test/cctest/test-parsing.cc:976: On 2011/12/07 15:59:33, Yang wrote:
Presubmit check says
test/cctest/test-parsing.cc:975: Using sizeof(type). Use
sizeof(varname)
instead if possible [runtime/sizeof] [1]
Done. http://codereview.chromium.org/8844002/diff/1/test/cctest/test-parsing.cc#newcode1071 test/cctest/test-parsing.cc:1071: int length = i::OS::SNPrintF( program, On 2011/12/07 15:59:33, Yang wrote:
Presubmit says
test/cctest/test-parsing.cc:1071: Extra space after ( in function
call
[whitespace/parens] [4]
Done. http://codereview.chromium.org/8844002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
