I have to agree with Kevin. These are purely cosmetic changes (full
disclosure:
I only randomly sampled, I don't have the time to go through all). If such
changes were on the C/C++ code base to ensure maintainability, that would
be one
thing, but the tests rarely get changed, and so I don't see the net added
value
of this enormous CL. Please tell me that I am missing something?
On 2011/12/08 11:20:51, Kevin Millikin wrote:
Drive by: is this necessary?
For failing tests, it's sometimes nice to ask the person who last
modified the
code what the code is intended to test.
This makes that person you for a number of tests.
http://codereview.chromium.org/8888006/diff/1/src/array.js
File src/array.js (right):
http://codereview.chromium.org/8888006/diff/1/src/array.js#newcode1
src/array.js:1: // Copyright 2010 the V8 project authors. All rights
reserved.
Here and elsewhere 2011.
http://codereview.chromium.org/8888006/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
