My vote is that cleaning up the tests isn't worth it. I'm all for making them clean going forward: cleanup if they're edited, and instructions to developers and reviewers to also pay attention to style in tests.
On Thu, Dec 8, 2011 at 1:41 PM, <[email protected]> wrote: > You have a point. The changes should be entirely cosmetic, and is merely to > bring our existing code closer to the coding standard that new code should > use > (and the old code just shows that we haven't been that good at sticking to > so > far). > It should also have the advantage of being a good example for new code - > if new > authors look at old code to see how to write it, the old code should be a > good > example. > > The tests might not be worth it though. > > Maybe I should just restrict the fixups to the internal javascript files > (src/*.js)? These are being actively developed, where the tests are > write-once > and only look back if they fail. > > > > http://codereview.chromium.**org/8888006/<http://codereview.chromium.org/8888006/> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
