http://codereview.chromium.org/8822014/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right):
http://codereview.chromium.org/8822014/diff/1/src/mips/lithium-codegen-mips.cc#newcode3000 src/mips/lithium-codegen-mips.cc:3000: On 2011/12/06 16:21:53, Yang wrote:
From what I can see, you don't need to reserve an additional temp
register (and
change register allocation in lithium-mips.cc) if you can already take
advantage
of a double_scratch0(). Or is this double_scratch0() somehow related to kDoubleRegZero?
I generally try to stick close to the ARM version because in my experience it makes long-term maintenance easier. However if this has a performance impact or you feel that the code is better the other way, I will obviously change it. The change is not related to kDoubleRegZero. http://codereview.chromium.org/8822014/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
