[v8-dev] Re: Optimize the equality check case of ICCompare stubs. (issue 8520006)

Thu, 08 Dec 2011 05:38:19 -0800

LGTM, except I'm not sure why we never look compare stubs in the map code cache. 

http://codereview.chromium.org/8520006/diff/48001/src/code-stubs.cc
File src/code-stubs.cc (right):

http://codereview.chromium.org/8520006/diff/48001/src/code-stubs.cc#newcode131
src/code-stubs.cc:131: // Update the dictionary and the root in Heap.
Move this comment into the else branch.

http://codereview.chromium.org/8520006/diff/48001/src/code-stubs.cc#newcode183
src/code-stubs.cc:183: return false;
Why don't we look it up in the map?

http://codereview.chromium.org/8520006/diff/48001/src/heap.h
File src/heap.h (right):

http://codereview.chromium.org/8520006/diff/48001/src/heap.h#newcode238
src/heap.h:238: V(compare_ic_symbol, "compare_ic")
              \
Maybe choose a symbol that isn't a valid identifier so it is less likely
to clash with property names?

http://codereview.chromium.org/8520006/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev






















					Reply via email to