Added lookup in the map cache, please take a quick look on this
http://codereview.chromium.org/8520006/diff/48001/src/code-stubs.cc File src/code-stubs.cc (right): http://codereview.chromium.org/8520006/diff/48001/src/code-stubs.cc#newcode131 src/code-stubs.cc:131: // Update the dictionary and the root in Heap. On 2011/12/08 13:38:15, Kevin Millikin wrote:
Move this comment into the else branch.
Done. http://codereview.chromium.org/8520006/diff/48001/src/code-stubs.cc#newcode183 src/code-stubs.cc:183: return false; On 2011/12/08 13:38:15, Kevin Millikin wrote:
Why don't we look it up in the map?
Done. http://codereview.chromium.org/8520006/diff/48001/src/heap.h File src/heap.h (right): http://codereview.chromium.org/8520006/diff/48001/src/heap.h#newcode238 src/heap.h:238: V(compare_ic_symbol, "compare_ic") \ On 2011/12/08 13:38:15, Kevin Millikin wrote:
Maybe choose a symbol that isn't a valid identifier so it is less
likely to
clash with property names?
Done. http://codereview.chromium.org/8520006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
